Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output doc comments for package, structs, and fields. #405

Merged
merged 4 commits into from
Jun 18, 2024

Conversation

blorgbeard
Copy link
Contributor

Support for generating doc comments from avro "doc" attributes in the schema.

Also added an optional command-line argument to supply a package doc comment.

gen/output_template.tmpl Outdated Show resolved Hide resolved
gen/output_template.tmpl Outdated Show resolved Hide resolved
@blorgbeard blorgbeard force-pushed the generate-doc-comments branch 3 times, most recently from 01b716c to bdc5dc3 Compare June 10, 2024 02:19
Copy link
Member

@nrwiersma nrwiersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a couple comments.

gen/gen.go Outdated Show resolved Hide resolved
gen/gen.go Outdated Show resolved Hide resolved
@blorgbeard blorgbeard force-pushed the generate-doc-comments branch 2 times, most recently from 6773afe to ee6a54b Compare June 17, 2024 21:57
gen/gen.go Outdated Show resolved Hide resolved
Copy link
Member

@nrwiersma nrwiersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 Thanks for the contribution

@nrwiersma nrwiersma merged commit 8fff381 into hamba:main Jun 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants