add support for recursive schemas & structs

[adrianiacobghiula]

No description provided.

[nrwiersma]

Any particular reason you chose this approach over passing a DecoderContext/EncoderContext through?

[adrianiacobghiula]

Just a matter of personal way of coding, I tend to have the functions on a struct rather than having free-floating with large names createDecoderOfMap() vs encoderCreator.ofMap() because of input parameters, long-names & cohesion

[nrwiersma]

Fair. This has however created some inconsistency in the module as a whole. For example createDefaultDecoder still exists with the old signature. (d decoderCreator) newEfaceDecoder is actually a constructor but has been attached.

[adrianiacobghiula]

Pushed improvements. I do have one question: What does eface stands for ?

[nrwiersma]

Interfaces are split into 2 types, an empty interface (interface{} or any) eface and a populated (has methods) interface iface.

[nrwiersma]

The issue this poses is that it fundamentally changes the codebase far beyond what is required to implement the feature. In fact I see a couple ways to do it without putting everything under a struct. Part of this also subtly changes how this works in ways I don't fully understand the impact of yet. I am not making any argument of the relative benefits of either approach. Both are perfectly valid, and were I to completely rewrite today, perhaps a different approach would be chosen.

As an example, this changes the benchmark of the library for the worse (~224ns to ~230ns), but it would be very difficult to pin down exactly were the degraded performance comes from, small as it may be.

[adrianiacobghiula]

So you would not have decoderCreator or encoderCreator but replace the parameter cfg *frozenConfig to another object like DecoderContext (that contains the cfg *frozenConfig & the map ?) to every function createDecoderOfMap, decoderOfType, createDecoderOfMarshaler ?

[nrwiersma]

Yes. That seems like it should work.

[adrianiacobghiula]

@nrwiersma pushed using DecoderContext & EncoderContext

[nrwiersma]

Nice addition, thanks. A couple comments.

[nrwiersma]

LGTM 🎉 Thanks for the contribution.