Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start checkstyle setup 2 #217

Merged
merged 1 commit into from
Sep 3, 2019
Merged

Start checkstyle setup 2 #217

merged 1 commit into from
Sep 3, 2019

Conversation

krichter722
Copy link
Contributor

As suggested in #214 the checkstyle setup can be put forward step by
step in order to minimize controversy. The start contains a rule to
enforce spaces instead of tab characters which are already used in
roughly 99.99% of the source.

As suggested in #214 the checkstyle setup can be put forward step by
step in order to minimize controversy. The start contains a rule to
enforce spaces instead of tab characters which are already used in
roughly 99.99% of the source.
@krichter722
Copy link
Contributor Author

@sf105 This could be a start for checkstyle. You could collect experience over time.

@tumbarumba
Copy link
Member

As a simple start, I like this, and it shows the value of having a check like this (some tab characters have snuck into the codebase).

Are there any objections to merging this?

@sf105
Copy link
Member

sf105 commented Aug 26, 2019

As Karl-Philipp and I discussed already, I'm not keen to add checkstyle to the build as, at the moment it's very simple with hardly any dependencies. I'm not convinced that it brings enough benefit for a lot of imports (it's Joe Armstrong's old line about wanting the banana but getting the whole jungle). That said, this is your show now, so you make the call.

@tumbarumba tumbarumba merged commit c5e9c50 into hamcrest:master Sep 3, 2019
@tumbarumba
Copy link
Member

Calling! It's in! This happens to be a jungle I happen to like. As the random tabs show, keeping consistency in a codebase with a number of different contributors can be tricky. I think tools like this help with consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants