Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix it not being gcsafe #1

Merged
merged 1 commit into from
Aug 6, 2023
Merged

Conversation

lost-rob0t
Copy link

This is my First PR, please Correct anything that is wrong here.

I noticed when i was trying to use it with Prologue web framework that nim was complaining that it was not gc safe?
I found adding that flag had nim stop complaining about it.

@hamidb80
Copy link
Owner

hamidb80 commented Aug 6, 2023

Hey,
Does library still work today?

I thought it's broken since it uses some deleted functions in package macroplus

It definitely needs cleanup

@lost-rob0t
Copy link
Author

Yup it works, Didn't even know about the changes.
Im not sure about the queryserver, I havent tried that.
But the normal CRUD Does work.

@hamidb80 hamidb80 merged commit 5201b4a into hamidb80:main Aug 6, 2023
@hamidb80
Copy link
Owner

hamidb80 commented Aug 6, 2023

Thanks for pull request, I will make a new release when I tested it

@hamidb80
Copy link
Owner

hamidb80 commented Aug 6, 2023

what I really wanna do is to make APIs type-checked like what I did in my Bale bot API

I marked all of the responses as distinct JsonNode

@hamidb80
Copy link
Owner

hamidb80 commented Aug 6, 2023

I've tested it on CouchDB v3.3.2 (because couldn't find 3.1.1 binary for Windows).
_update and node_config API's does not work, anything else has no problem.

happy coding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants