Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot access private property Security::$autologin_enabled #20

Open
blpraveen opened this issue Oct 8, 2014 · 5 comments
Open

Cannot access private property Security::$autologin_enabled #20

blpraveen opened this issue Oct 8, 2014 · 5 comments

Comments

@blpraveen
Copy link

Getting this error when I install on 3.1 Silverstripe Version

@Realys-31
Copy link

Me too... i use SS v3.1.8

@Realys-31
Copy link

Quickly...
I have comment line 72 to 79 in "code/ExternalLoginForm.php" :
/*
if(Security::$autologin_enabled) {
$fields->push(new CheckboxField(
"Remember",
_t('ExternalAuthenticator.Remember','Remember me next time?'),
Session::get('SessionForms.ExternalLoginForm.Remember'),
$this
));
}
*/

It's ok now !
So there is no remember me checkbox... Not important for test.
++

@svandragt
Copy link

If you replace line 72 with
if (Security::config()->autologin_enabled) {
then it will probably work without having to comment out the code.

@Amenel
Copy link

Amenel commented Jul 16, 2016

@svandragt Rewriting that line as you wrote it does the trick! But we are modifying external modules. Sub-optimal I guess, unless this has been superseded (as the official repo for the auth-external module) by a fork? I see that you were the last modifier on this repo. Any chance that the correct line gets into the master branch? I guess that will also require bumping the compatibility listed in the requirements to SilverStripe 3.1.

@svandragt
Copy link

This module is in need of some maintenance. I am no longer using SilverStripe at work as I switched jobs so it's more difficult to make time to do a 3.1 compatible review but I would accept pull requests.

Sander

On 16 Jul 2016, 17:20 +0100, Amenelnotifications@github.com, wrote:

@svandragt(https://github.com/svandragt)Rewriting that line as you wrote it does the trick! But we are modifying external modules. Sub-optimal I guess, unless this has been superseded (as the official repo for the auth-external module) by a fork? I see that you were the last modifier on this repo. Any chance that the correct line gets into the master branch? I guess that will also require bumping the compatibility listed in the requirements to SilverStripe 3.1.


You are receiving this because you were mentioned.
Reply to this email directly,view it on GitHub(#20 (comment)), ormute the thread(https://github.com/notifications/unsubscribe-auth/AAkTt2IG-KBDiwsOwuGA-ByAMgede1czks5qWQTbgaJpZM4CsP0I).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants