Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: minimap export crash #304

Merged
merged 1 commit into from
Apr 29, 2020
Merged

fix: minimap export crash #304

merged 1 commit into from
Apr 29, 2020

Conversation

gpedro
Copy link
Collaborator

@gpedro gpedro commented Apr 23, 2020

related #297

@gpedro gpedro requested review from Elime1 and Mignari April 23, 2020 12:40
@Mignari
Copy link
Collaborator

Mignari commented Apr 23, 2020

dialog.Destroy() is being used correctly in this case. Are you sure this is the cause of it?

@gpedro
Copy link
Collaborator Author

gpedro commented Apr 23, 2020

sure...dialog.Destroy() are crashing export minimap after you choose the file.

Mignari
Mignari approved these changes Apr 23, 2020
View reviewed changes
Copy link
Collaborator

@Mignari Mignari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works as expected

@gpedro gpedro requested review from hampusborgos and removed request for Elime1 April 28, 2020 19:20
@Mignari Mignari merged commit cb7c45c into hampusborgos:master Apr 29, 2020
Mignari added a commit that referenced this pull request May 18, 2020
@Mignari
Fix crash when exporting search result
a61302a 
Same of #297 #304
Probably calling dispose() causes crash after opening a dialog box for directories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mignari Mignari Mignari approved these changes

@hampusborgos hampusborgos Awaiting requested review from hampusborgos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gpedro @Mignari