Skip to content

Commit

Permalink
Fix stray error return in WikiPage::setText(); add changelog entry
Browse files Browse the repository at this point in the history
  • Loading branch information
Xymph committed Aug 26, 2021
1 parent 72f9cdc commit eed4aff
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@ and [Keep a Changelog](http://keepachangelog.com/).
* Added additional context to README.md ([#127])
* Added semi-linear merge recommendation to GOVERNANCE.md ([#130])

_The following entry is a backwards incompatible API change
and may require changes in applications that invoke these methods:_

* Error return values for `WikiPage::getSection()` changed from `false` to `null`, and for `setText()` from `null` to `false` ([#129])

#### Removed

* Method `Wikimate::debugCurlConfig()`, deprecated since v0.10.0 ([#128])
Expand Down Expand Up @@ -169,4 +174,5 @@ and [Keep a Changelog](http://keepachangelog.com/).
[#125]: https://github.com/hamstar/Wikimate/pull/125
[#127]: https://github.com/hamstar/Wikimate/pull/127
[#128]: https://github.com/hamstar/Wikimate/pull/128
[#129]: https://github.com/hamstar/Wikimate/pull/129
[#130]: https://github.com/hamstar/Wikimate/pull/130
2 changes: 1 addition & 1 deletion Wikimate.php
Original file line number Diff line number Diff line change
Expand Up @@ -1308,7 +1308,7 @@ public function setText($text, $section = null, $minor = false, $summary = null)
// Check for errors
if (isset($r['error'])) {
$this->error = $r['error']; // Set the error if there was one
return null;
return false;
} else {
$this->error = null; // Reset the error status
}
Expand Down

0 comments on commit eed4aff

Please sign in to comment.