You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running PHPDoc (v2.9.1) highlighted that most class properties and constants were lacking comments, and existing ones were incomplete. Also, parameters to the Wikimate constructor method weren't documented, and the main file header was misformatted using /// comments.
By the way, could you add this comment in the PR diff, rather than the stand-alone commit page? GitHub get a bit confused by comments added there, and they can't be marked as resolved. (If you do that, I'll copy my response as well, and then we can delete the comments from the commit page to clean things up.) (Update: done)
By the way, could you add this comment in the PR diff, rather than the stand-alone commit page? GitHub get a bit confused by comments added there, and they can't be marked as resolved. (If you do that, I'll copy my response as well, and then we can delete the comments from the commit page to clean things up.)
Copied, and original comment removed. The constant itself is also gone.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running PHPDoc (v2.9.1) highlighted that most class properties and constants were lacking comments, and existing ones were incomplete. Also, parameters to the Wikimate constructor method weren't documented, and the main file header was misformatted using /// comments.