Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Infallible to LambdaError on hyper #13

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Replace Infallible to LambdaError on hyper #13

wants to merge 1 commit into from

Conversation

namse
Copy link

@namse namse commented Sep 1, 2022

Related issue: #12

I replaced Infallible to LambdaError for supporting error handling on hyper.

@namse namse mentioned this pull request Sep 2, 2022
Merged
@hanabu
Copy link
Owner

hanabu commented Jan 8, 2023

Thank you for your contribution.

But, with your change, axum or warp web frameworks can not compile with this.
Both frameworks assume Service with Error=Infallible e.g., axum::Router,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@namse @hanabu