Add support for Ruby 3.4 #413
Open
+18
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still get ostruct warnings but it's only used in a couple specs so I think we should rework the specs to not use OpenStruct... or we could just add it to the Gemfile because it's a default gem. Which do you think is better? Feel free to make either change to this PR or defer to a future PR since it's just a warning.
Note that we have to add the dependency on bigdecimal because it's a bundled gem, which means it's installed with ruby but it can be removed by users. If users removed it, then our dependency is missing and this library breaks. So we have define it in the gemspec.