Use setting kwargs to fit new dry-configurable API #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timriley
force-pushed
the
use-kwargs-for-dry-configurable-settings
branch
from
7184111 to
a2d5832
Compare
Gemfile
Outdated
| @@ -8,6 +8,8 @@ eval_gemfile "Gemfile.devtools" | |||
|
|
|||
| gemspec | |||
|
|
|||
| gem "dry-configurable", git: "https://github.com/dry-rb/dry-configurable.git", branch: "master" | |||
There was a problem hiding this comment.
Hey @timriley , is this new line supposed to be here, or is it a leak from your debugging session? 🙂
There was a problem hiding this comment.
@waiting-for-dev Thanks for checking :) It's needed here for the time being, to allow the tests on the master branch to pass. Without this they'll fail because they don't work with the latest release of the dry-configurable gem.
When it comes to preparing all these changes for release, I'll do it in the right order (e.g. dry-configurable first, others afterwards) and pull out these Gemfile entries before each release.
timriley
force-pushed
the
use-kwargs-for-dry-configurable-settings
branch
from
a2d5832 to
4110cc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
settingdeclarations to use the updated dry-configurable API, which usesdefault:andconstructor:instead of second positional arg and trailing block arg respectively.This will also unbreak the view integration tests on hanami/hanami for Ruby 2.6 and 2.7, due to their misinterpretation of a hash argument as keyword arguments.