Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for "App" mappings without a Bundle class #31

Merged
merged 3 commits into from
Oct 27, 2022
Merged

Conversation

AndreasA
Copy link

It is not optimal because it "fakes" a bundle by using a class in the app's source root - by default App\Kernel or optionally any other class. The advantage is that in most cases it works out of the box and in some others it can be fixed using a minor configuration change.

The main advantage is, that as there is no bundle configured there will be no unintended side consequences (as I mentioned in the corresponding issue).

Fixes: #15

DependencyInjection/Configuration.php Outdated Show resolved Hide resolved
Mapping/DocumentFinder.php Outdated Show resolved Hide resolved
Mapping/DocumentFinder.php Outdated Show resolved Hide resolved
Resources/doc/mapping.md Outdated Show resolved Hide resolved
Resources/doc/mapping.md Outdated Show resolved Hide resolved
@alexander-schranz alexander-schranz changed the title Added support for "App" mappings. Add support for "App" mappings without a Bundle class Oct 27, 2022
@alexander-schranz alexander-schranz added the enhancement New feature or request label Oct 27, 2022
@alexander-schranz alexander-schranz merged commit 788d90f into handcraftedinthealps:5.x Oct 27, 2022
@alexander-schranz
Copy link
Member

@AndreasA Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bundle 'App' does not exist.
2 participants