Avoid the use of length attribute in custom helpers

[ManasJayanth]

When I compiled the following code

Usage:

{{#condense}}
{{#each usage}}
    {{#cyan}}bower{{/cyan}} {{.}}
{{/each}}
{{/condense}}


Options:

{{#condense}}
{{#each options}}
    {{#yellow}}{{#rpad length="23"}}{{#if shorthand}}{{shorthand}}, {{/if}}{{flag}}{{/rpad}}{{/yellow}} {{description}}
{{/each}}
{{/condense}}

    Additionally all global options listed in 'bower help' are available

Description:

    {{#indent level="4"}}{{description}}{{/indent}}

the following exception was observed.

/Users/prometheansacrifice/development/js/handlebars-ex/node_modules/handlebars/dist/cjs/handlebars/compiler/javascript-compiler.js:759
    hash.values[key] = value;
                     ^

RangeError: Invalid array length
    at Object.assignToHash (/Users/prometheansacrifice/development/js/handlebars-ex/node_modules/handlebars/dist/cjs/handlebars/compiler/javascript-compiler.js:759:22)
    at Object.compile (/Users/prometheansacrifice/development/js/handlebars-ex/node_modules/handlebars/dist/cjs/handlebars/compiler/javascript-compiler.js:113:27)
    at Object.compileChildren (/Users/prometheansacrifice/development/js/handlebars-ex/node_modules/handlebars/dist/cjs/handlebars/compiler/javascript-compiler.js:794:49)
    at Object.compile (/Users/prometheansacrifice/development/js/handlebars-ex/node_modules/handlebars/dist/cjs/handlebars/compiler/javascript-compiler.js:97:10)
    at Object.compileChildren (/Users/prometheansacrifice/development/js/handlebars-ex/node_modules/handlebars/dist/cjs/handlebars/compiler/javascript-compiler.js:794:49)
    at Object.compile (/Users/prometheansacrifice/development/js/handlebars-ex/node_modules/handlebars/dist/cjs/handlebars/compiler/javascript-compiler.js:97:10)
    at Object.compileChildren (/Users/prometheansacrifice/development/js/handlebars-ex/node_modules/handlebars/dist/cjs/handlebars/compiler/javascript-compiler.js:794:49)
    at Object.compile (/Users/prometheansacrifice/development/js/handlebars-ex/node_modules/handlebars/dist/cjs/handlebars/compiler/javascript-compiler.js:97:10)
    at compileInput (/Users/prometheansacrifice/development/js/handlebars-ex/node_modules/handlebars/dist/cjs/handlebars/compiler/compiler.js:516:53)
    at ret (/Users/prometheansacrifice/development/js/handlebars-ex/node_modules/handlebars/dist/cjs/handlebars/compiler/compiler.js:523:18)

which can be traced to the following line

hash.values[key] = value;

On logging, I realised 'lengthis being set onhash.valueswith the value"23"`, which threw the RangeError.

Handlebars could prevent the use of reserved keywords in attributes for custom helpers

Handlebars version: 4.0.5

[kpdecker]

Is this available on a public repository somewhere that we can run it locally?

[ManasJayanth]

Try this repo

[kpdecker]

Thanks for the report. I've fixed this in master and added a test for it.

[ManasJayanth]

Appreciate it. Thank you too.

[philippe-granet]

@kpdecker @nknapp This fix is not reported in branch 3.x or 4.x ?

[nknapp]

Appearently not. I don't know why my name appears next to the commit 7d5dba4. I don't recall anything about it. I'm not sure if there are any backward-compatibility issues. If not, and if somebody created a PR for 4.x (and 3.x if needed) containing only this commit, I would merge it. Am 2019-01-17 11:20, schrieb Philippe GRANET:

…

@kpdecker [1] @nknapp [2] This fix is not reported in branch 3.x or 4.x ? -- You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub [3], or mute the thread [4]. Links: ------ [1] https://github.com/kpdecker [2] https://github.com/nknapp [3] #1194 (comment) [4] https://github.com/notifications/unsubscribe-auth/AAm09rrplOZ7XqP5g57v7DKsmx0-I6nWks5vEE5qgaJpZM4Hp9D_