Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v4.7.8 #1966

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Release v4.7.8 #1966

merged 1 commit into from
Aug 1, 2023

Conversation

jaylinski
Copy link
Member

@jaylinski jaylinski commented Jul 27, 2023

It is time...

for a new release.

This PR prepares a new patch-release and updates release-instructions.

Note: the release system will be kept as is for the 4.x-branch but will be updated for 5.x.

Closes #1918.

Commit diff

v4.7.7...4.x

npm publish diff

npm diff --diff=handlebars@4.7.7 --diff=handlebars-jaylinski@4.7.8

Comparison with previous release

a9a8e40

@nknapp
Copy link
Collaborator

nknapp commented Jul 28, 2023

I have quickly scanned through the changes since the last release. Good work on that and thank you for your support. I have a few questions/remarks though. Nothing that is blocking the release...

As for the release: It has been a long while since I have published one. But if I recall correctly, I never used a release-branch. Is there any reason why the newer commits on the 4.x branch shouldn't be part of the release?

@jaylinski
Copy link
Member Author

jaylinski commented Jul 29, 2023

@nknapp Thanks for the review.

  • Regarding the markdown formatting with prettier: this was only done in lint-staged-husky command, put not in npm run format. That's why I removed it. I re-added it in this PR: Format *.md files with prettier #1976
  • True, do you have a suggestion? I'm not sure, since i for iteration seems already not that bad 😅

Regarding the release branch: it already contains all commits from 4.x. But I only added non-chore commits to the release-notes.

@jaylinski jaylinski merged commit 8dc3d25 into 4.x Aug 1, 2023
15 checks passed
@jaylinski jaylinski deleted the 4x-release branch August 1, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants