-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Requires the file package to work in node or browserify. #220
Conversation
why does handlebars need this? Could it be removed altogether? |
@shtylman I think this is for precompilation. |
@jamesotron What version of Node? I've installed the Handlebars NPM package and not had any issues. |
I have had the same problem in browserify and script. It works in node tho. Just not when you try to use the client side bundlers. |
Sorry for going incommunicado for a few days - my whole family came down with the flu. Regardless, I'm using Node 0.6.15. |
@jamesotron I have 0.6.11. I wouldn't have expected much significant to change in a minor point release, but maybe it has. |
@jamesotron Will this work for older versions of Node, since we only require |
@jamesotron What error are you seeing that led you to this? The only reference to a file module that I could find was in the parser's generated code which as best I can tell is not used.
|
I'm getting this when I try to push it to a phonegap environment with browserify and Zepto:
|
I think this is a result of static analysis via browserify. I have a test branch setup locally that modifies the parser slightly to handle this in a better manner but I need to check into some cleanup there before I can commit it. |
Removes unnecessary commonjs code generated for the parser. This reduces the size of the parse by about 700bytes and should resolve lookup issues with browserify and other static analysis tools. See #220
3cac267 should resolve this issue as the unnecessary code will not be generated anymore. |
Handlebars depends on the "file" npm package to function under browserify or node.js.