Fix colorcycle #32
Merged
Fix colorcycle #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 15, 2019 00:21
* In handley-lab#21 the calls of `ax.plot([], [])` and similar were changed to setting `x = []` and passing it to the plotting functions. - This does not take care of the different colour cycles of plot and scatter and thus does not work. Changes to be committed: * modified: anesthetic/samples.py
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
==========================================
- Coverage 90.32% 89.95% -0.37%
==========================================
Files 14 14
Lines 982 986 +4
==========================================
Hits 887 887
- Misses 95 99 +4
Continue to review full report at Codecov.
|
williamjameshandley
approved these changes
Jul 15, 2019
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #21 the calls of
ax.plot([], [])and similar were changed to settingx = []and passing it to the plotting functions. This does not take care of the different colour cycles of plot and scatter and thus does not work.Thus, here I am reverting some of the changes from #21.
It might be good to write a test for this where it actually checks the colours used. This might be much easier once #30 is merged.
Fixes #31
Checklist:
flake8 anesthetic tests)pydocstyle --convention=numpy anesthetic)python -m pytest)