Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emulated termination criteria #363
base: master
Are you sure you want to change the base?
Emulated termination criteria #363
Changes from 10 commits
387ff78
8fd2ac1
ad1d358
01ce2a9
365b85c
9708866
17505fa
4ee2b73
6fc79b5
4016ccf
43fa01d
2888a4f
f9d3e68
41ada6c
77e6cd9
97e248e
849d629
0ec4a2c
999526f
51097bd
75d8628
c662252
8a1117f
5ef5cd9
0fec842
fdb5b24
8dc9b87
e414992
a34b3d6
26c0603
4a5141c
bf4c30c
a878699
68a3043
9a70d46
b1cda3a
27f5ddb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In hindsight, do we need the dead points?
self.logX()[i_live[0]] + logZ_live
vsself.logZ()
would probably also do the trick.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I see this, if I am taking the ratio, self.logZ() is the union whereas I want the
self.iloc[dead].logZ()
? So I think I need dead idx? I will implement all the other suggestions and resend for comments