-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
automatic minmax limits #80
Conversation
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
==========================================
+ Coverage 91.15% 91.19% +0.03%
==========================================
Files 15 15
Lines 1323 1329 +6
==========================================
+ Hits 1206 1212 +6
Misses 117 117
Continue to review full report at Codecov.
|
`x0` and `x1` in the pc example data are both Gaussians with their limits set to `None` in the .ranges file. I removed the limits on `x1` such that the expected behaviour now (with auto minmax limits) should be: * `x0` limits are set to (None, None) as specified in .ranges file * `x1` limits will be set to (x1.min(), x1.max()) automatically
This looks great. I've had a quick look and it seems like it works well. Could you iterate the version number in the README to 1.2.6 to signify a change, and I'll formalise this as a new release. |
I noticed one thing: |
I think it makes sense to automate this too. It would be harder to communicate in the case that you don't want a hard limit, but you could always do that manually at the python level if you had to. You should probably also do this for the nlive column as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Please squash and merge!
…amples and NestedSamples
Automatically set all limits not specified by a
.ranges
file to their respective minimum and maximum values in the sample.Fixes #36
Checklist:
flake8 anesthetic tests
)pydocstyle --convention=numpy anesthetic
)python -m pytest
)