Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI: use the same Ruby version in CI and Gemfile.lock #165

Conversation

handshake-enthusiast
Copy link
Contributor

No description provided.

@handshake-enthusiast
Copy link
Contributor Author

While this worked it would be better to use the same Ruby version (3.0.3) which is used in Gemfile.lock. I'm changing to that version.

@handshake-enthusiast handshake-enthusiast changed the title fix CI by installing Ruby 3.1 Fix CI: use the same Ruby version in CI and Gemfile.lock Jan 10, 2023
@handshake-enthusiast
Copy link
Contributor Author

Before:

Run ruby/setup-ruby@v1
  with:
    ruby-version: 3
    bundler-cache: true
    
Downloading Ruby
  https://github.com/ruby/ruby-builder/releases/download/toolcache/ruby-3.2.0-ubuntu-22.04.tar.gz

Ruby 3.2.0 couldn't install nokogiri during Run ./bin/build.

After:

Run ruby/setup-ruby@v1
  with:
    ruby-version: 3.0.3
    bundler-cache: true
    
Downloading Ruby
  https://github.com/ruby/ruby-builder/releases/download/toolcache/ruby-3.0.3-ubuntu-22.04.tar.gz

Very strange previously it was installing Ruby 3.2 instead of 3.0 even though https://github.com/ruby/setup-ruby#supported-version-syntax says:

short version like '2.6', automatically using the latest release matching that version (2.6.10)

@handshake-enthusiast
Copy link
Contributor Author

Explained ruby/setup-ruby#442 (comment)

@handshake-enthusiast
Copy link
Contributor Author

You can merge this PR in order to make other PRs green (e.g. #170 and #171).

@pinheadmz @nodech (not sure who else is active and has merge rights)

@nodech nodech closed this Mar 20, 2023
handshake-enthusiast added a commit to handshake-enthusiast/handshake-org.github.io that referenced this pull request Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants