Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WalletDB should re-emit block events #621

Closed
pinheadmz opened this issue Jul 23, 2021 · 0 comments · Fixed by #707
Closed

WalletDB should re-emit block events #621

pinheadmz opened this issue Jul 23, 2021 · 0 comments · Fixed by #707
Labels
Good first issue issues - beginners and people unfamiliar with code

Comments

@pinheadmz
Copy link
Member

pinheadmz commented Jul 23, 2021

This is a pretty simple feature that would make GUI applications easier, for example right now Bob has to unhook rescan events from the wallet client and MITM them in order to notify the user: https://github.com/kyokan/bob-wallet/blob/master/app/background/wallet/service.js#L888-L890

WalletDB (well, wallet and txdb actually) already emit events for tx, address, and a few others but not for blocks.

Possibly the easiest approach would just be to re-emit events from the wallet's node client right after its done processing them: https://github.com/handshake-org/hsd/blob/master/lib/wallet/walletdb.js#L132-L154

Don't forget to add tests to your PR!

@nodech nodech added Good first issue issues - beginners and people unfamiliar with code and removed good first issue labels Nov 18, 2021
@handshake-org handshake-org deleted a comment from sujantkumarkv Jan 5, 2022
@handshake-org handshake-org deleted a comment from sujantkumarkv Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue issues - beginners and people unfamiliar with code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants