-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPV, RPC, Rescan fixes #469
Conversation
850b6b4
to
1924dd8
Compare
👍 looks good so far. |
@rithvikvibhu re: 7af427a I think we can make this a lot simpler by adding a feature to hsd: handshake-org/hsd#621 If wallet and node both emit "new chain height" events, we will always know their sync status and we can drop the bob-wallet/app/background/wallet/service.js Line 203 in de90b37
|
@pinheadmz using hsd fork (handshake-org/hsd#707) and yeah it made things simpler! SPV importname is still a problem though. |
And better rescan for SPV and RPC
Rebased, updated to hsd v4.0.1 and it's SO satisfying to watch the auction rescan in SPV! |
SPV, RPC and rescan fixes. Redid commits to make review easier.
node: set spv boolean correctly
ui: hide generatenewblocks if spv
node: remove getAuctionInfo
node: common api url constant
exchange: disable in spv mode
rpc: allow http for private IP addresses
binet
(added to package.json, but hsd itself requires it so doesn't add anything)rpc: splash screen switch to internal node on error
db
directory.node: throttle refreshNodeInfo
refreshNodeInfo
is a slightly expensive call (getInfo and getFees) and was being called for every new block, which is very fast in SPV modewallet: replace rescan hooks with block connect events
block connect
events.(1)
and(2)
:Now, rescans work everywhere and show proper status (next commit below):
wallet: correct resync progress in spv
pkg: update to hsd v4.0.1
hsd
to v4.0.1 which has net: fixes for SPV handshake-org/hsd#752 mergedOverall, SPV seems more stable now, and syncs from scratch in 25 minutes.
TODO: