Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc: add extra_nonce to block's JSON. #426

Merged
merged 2 commits into from
Apr 19, 2020
Merged

rpc: add extra_nonce to block's JSON. #426

merged 2 commits into from
Apr 19, 2020

Conversation

kilpatty
Copy link
Contributor

This feels like it should belong here, as I don't know if there is any other way to query the extra_nonce from blocks.

@tynes
Copy link
Contributor

tynes commented Apr 16, 2020

Good find. It could also be added in the headerToJSON function as well.

hsd/lib/node/rpc.js

Lines 2874 to 2876 in 9bdbadb

mediantime: mtp,
nonce: entry.nonce,
bits: hex32(entry.bits),

@kilpatty
Copy link
Contributor Author

Good catch, will update

@tynes
Copy link
Contributor

tynes commented Apr 19, 2020

This looks good to me. 44bd1bf

pinheadmz
pinheadmz approved these changes Apr 19, 2020
View reviewed changes
Copy link
Member

@pinheadmz pinheadmz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK @ 44bd1bf

nice thanks!

@boymanjor boymanjor merged commit 4178fd3 into handshake-org:master Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tynes tynes tynes approved these changes

@pinheadmz pinheadmz pinheadmz approved these changes

@boymanjor boymanjor boymanjor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kilpatty @tynes @boymanjor @pinheadmz