wallet: allow updating of claimed names

[tynes]

There is currently a bug in the wallet where it assumes that REGISTER outputs only come from REVEAL outputs. This prevents any name claim from ever updating their name using the wallet API. It is still possible to manually create the REGISTER transaction and broadcast it directly to the blockchain without using the wallet API. This is risky because a user could forget to create the transaction with the additional output containing the value "locked in the claim" to themselves.

hsd/lib/wallet/txdb.js

Lines 1703 to 1710 in 4178fd3

	case types.REGISTER: {
	assert(i < tx.inputs.length);
	const nameHash = covenant.getHash(0);
	const prevout = tx.inputs[i].prevout;
	const brv = await this.getReveal(nameHash, prevout);
	assert(brv);

REGISTER outputs can also come from CLAIM outputs when the name is reserved.

hsd/lib/covenants/rules.js

Lines 1218 to 1227 in 4178fd3

	case types.CLAIM:
	case types.REVEAL: {
	// Must be be linked.
	if (!output)
	return -1;
	// Reveal has to go to a REGISTER, or
	// a REDEEM (in the case of the loser).
	switch (covenant.type) {
	case types.REGISTER: {

These changes do not use rules.isReserved and instead directly use reserved.has to handle the case when the name is claimed before the claim period ends and then updated for the first time after the claim period ends.

Tests are included that test updating fake claims using the wallet (not the memwallet).

[pinheadmz]

I sort of think the test should be written without RPC. It takes the HTTP stuff and API stuff out of the equation. Maybe take a look at the tests in other txdb-focused patches: #262 and #387. If you focus only on the single module you are updating, you may find you can take out a lot of unnecessary stuff like the blockchain! And you may not have to even mine blocks or advance the namestate through its life cycle.

[tynes]

I migrated the tests to wallet-test.js and am no longer using the RPC interface. Still need to add tests that the balances are updating correctly and will remove wallet-claim-test.js.

[codecov-io]

Codecov Report

Merging #438 into master will increase coverage by 0.39%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #438      +/-   ##
==========================================
+ Coverage   61.99%   62.38%   +0.39%     
==========================================
  Files         129      129              
  Lines       34843    34843              
  Branches     5920     5922       +2     
==========================================
+ Hits        21600    21736     +136     
+ Misses      13243    13107     -136     

Impacted Files	Coverage Δ
lib/wallet/txdb.js	85.04% <100.00%> (+0.50%)	⬆️
lib/covenants/rules.js	73.04% <0.00%> (-0.15%)	⬇️
lib/script/script.js	59.32% <0.00%> (-0.09%)	⬇️
lib/wallet/walletdb.js	78.90% <0.00%> (+0.54%)	⬆️
lib/covenants/namestate.js	88.97% <0.00%> (+1.80%)	⬆️
lib/protocol/consensus.js	89.79% <0.00%> (+2.04%)	⬆️
lib/wallet/wallet.js	73.96% <0.00%> (+4.14%)	⬆️
lib/wallet/nullclient.js	88.37% <0.00%> (+4.65%)	⬆️
lib/blockchain/chainentry.js	79.62% <0.00%> (+20.37%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4178fd3...c533bde. Read the comment docs.

[tynes]

We could test this using txdb.abandon().

Added test coverage of this codepath.

[tynes]

Added pre and post assertions for wallet balance after indexing blocks/coins. This should be ready for another round of review @pinheadmz @boymanjor

[pinheadmz]

ok this is so close to landing! just down to the nittiest of nits.

[tynes]

@pinheadmz @boymanjor Nits are resolved

[pinheadmz]

ACK c533bde

Show Signature

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

ACK c533bdeb9212835e06391163e1cff0f21ba23c04
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEE5hdzzW4BBA4vG9eM5+KYS2KJyToFAl61UWEACgkQ5+KYS2KJ
yTpUKBAArROU9qIyFdzNEPMdpuljDx1bKCCJafg6+KmAkfuQhMvK/hibrIOoWPSU
DC7JW3tpyxdFczXfzJHRiTuS7l/lu+amthUksCoHyblFYxh/NWRwhPWXBiHVbiKY
lkWPXXBR6fwHSNJDpRuQks5Z6smW8NMm+rrFxezif+z8jVWjd4BnH1leT6pEratA
gVEbrM50t7wX+Jx+MdiLaVI0K2FGLmlmERDBRXJxUjJxEquZ3LDYdiFNBDlFEBOC
GrcGlkGhoTC1aU1hkWm510vev52qVJY2neMVnMwg4JL6v5hj/FlBtZ9ureJ4mIVw
+r/z6XcQ5IeFnzwllxezMgfR4qheL+wOEgLB9nKbn+KKw5QD+APw+kr4sa7s47dM
QEAmjzWkAcyddMnzGzxHppHgbcoxDZUoVSKdVk8DnZn5p6v+wuCJGGX1Lqmz7bXo
pUL7lEW/8xcGWoGnxaBWBwRO0D2hQogjUepdHbd5GqxG6VnPcrDDSP+0G3FtbZfb
vF5mwz11KtwMVIP82ooiZrujO0t+rsdqkdWLOAsckf0PpsCl0a/3iDoZJjIAbo6r
8oJHPkurUrQ9DDJmhtopcHR1Nbrjns6vA85lvwWmI8UM6syDCBf+kkRyEBLTFshx
Uj1q+PgxXSfU2TRROLTaaFQNbK1OX1JSUR2sBGBUt6nTTUwl6Ew=
=IMOH
-----END PGP SIGNATURE-----

pinheadmz's public key is on keybase