Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg: update lint and docs. #887

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Conversation

nodech
Copy link
Contributor

@nodech nodech commented Mar 4, 2024

Update ecmascript version in the linter.

Add rm-imports to the jsdoc. It allows us to annotate typedefs with typescript specific imports, w/o breaking the jsdoc generation. pinheadmz/bsdoc#1

It just removes imports, as if they did not exist.

There's better "import-aliases" plugin also implemented in the bsdoc. But It needs more testing how better generated docs get and if there are any issues in the output. So we can upgrade later, after more experimenting with it.

@nodech nodech added quick review difficulty - easy tooling part of the codebase labels Mar 4, 2024
@coveralls
Copy link

Coverage Status

coverage: 68.632% (+0.004%) from 68.628%
when pulling 37d37e4 on nodech:lint-docs
into f749f5c on handshake-org:master.

@nodech nodech merged commit 0a4f24b into handshake-org:master Mar 4, 2024
6 checks passed
@nodech nodech deleted the lint-docs branch March 4, 2024 12:44
@nodech nodech mentioned this pull request Nov 29, 2024
@nodech nodech mentioned this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quick review difficulty - easy tooling part of the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants