Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: change ownership resolver from google to cloudflare. #895

Merged
merged 1 commit into from
May 31, 2024

Conversation

nodech
Copy link
Contributor

@nodech nodech commented May 31, 2024

google DNS resolvers have limits on the size of the queries. cloudflare.com TXT sometimes is over that limit. Switch to cloudflare servers for now and make it configurable for tests.

@nodech nodech added the tests part of the codebase label May 31, 2024
@coveralls
Copy link

Coverage Status

coverage: 68.545% (-0.009%) from 68.554%
when pulling 35a848c on nodech:change-ownership-resolvers
into fe336ae on handshake-org:master.

Copy link
Contributor

@Anunayj Anunayj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I even tried flushing Google DNS Cache from here. Did not seem to work, query size is not a issue either (tested with large TXT records on my domain), probably some internal issue at Google DNS, likely better to switch to Cloudflare.

@nodech nodech merged commit 1daebd8 into handshake-org:master May 31, 2024
6 checks passed
@nodech nodech deleted the change-ownership-resolvers branch May 31, 2024 09:34
@nodech nodech mentioned this pull request Nov 29, 2024
@nodech nodech mentioned this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests part of the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants