This repository has been archived by the owner on Mar 16, 2021. It is now read-only.
Bump Handsontable to 8.0.0-beta.2 and make adjustments for the transition. #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g differences and new/removed settings - Bump Handsontable to 8.0.0-beta.2 for both dependencies and peerDependencies� - Modify the 'tsickle' dependency version range to temporarily avoid bigger updates in dependencies
|
It's impossible to build, as CI said. I also tried with the current development, as in the case of Vue. |
|
@aninde CI and your build error fail because as @jansiegel wrote:
Installing the latest |
wojciechczerniak
previously approved these changes
Jul 28, 2020
wojciechczerniak
approved these changes
Jul 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
8.0.0-beta2, including the typing differences and new/removed settings8.0.0-beta.2for both dependencies and peerDependenciestsickledependency version range to temporarily avoid bigger updates in dependencies (the later0.*versions seem to not be compatible withtypescript@3.4.5, while updating the typescript version causes the angular-related dependencies to fail - should be addressed later on)@angular/*dependencies from~8.0.0to^8.0.0because of anpm auditerrorprotractordevDependency to the latest version because of anpm auditerrornpm-registry-fetchas a devDependency to force a specific version that doesn't cause anpm auditerror.I could've avoided adding new devDependencies by updating angular to
v10, but it cased some additional issues, which would require more time to be investigated.How has this been tested?
This PR needs to be tested with the current
developof Handsontable, as there were some changes in the TS typings in handsontable/handsontable#7145 (that's why the tests are failing on the CI)