Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade typescript, typedoc & vuepress #1262

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from
Draft

Conversation

sequba
Copy link
Contributor

@sequba sequba commented May 7, 2023

Context

Upgraded:

  • typescript@5.0.4

Other dependencies that also needed to be upgraded to work with the new typescript:

  • jest@29 (some adjustments were made to make it work)
  • ts-jest@29
  • karma@6
  • typedoc@0.24.6
  • vuepress@1.9.9
  • eslint@7

TODO: Typedoc had a lot of breaking changes. It requires significant effort to make our documentation work with the new version.

How did you test your changes?

  • local build
  • run unit test
  • local docs build -> DOESN'T WORK!

Types of changes

  • Breaking change (a fix or a feature because of which an existing functionality doesn't work as expected anymore)
  • New feature or improvement (a non-breaking change that adds functionality)
  • Bug fix (a non-breaking change that fixes an issue)
  • Additional language file, or a change to an existing language file (translations)
  • Change to the documentation

@github-actions
Copy link

github-actions bot commented May 7, 2023

Performance comparison of head (b2cdc52) vs base (f6f0102)

                                     testName |  base |   head |  change
------------------------------------------------------------------------
                                      Sheet A | 790.9 | 1093.2 | +38.22%
                                      Sheet B | 377.9 |  455.8 | +20.61%
                                      Sheet T | 381.8 |    470 | +23.10%
                                Column ranges | 855.7 |  901.3 |  +5.33%
Sheet A:  change value, add/remove row/column |    44 |     49 | +11.36%
 Sheet B: change value, add/remove row/column |   408 |    434 |  +6.37%
                   Column ranges - add column |   304 |    356 | +17.11%
                Column ranges - without batch |   914 |   1008 | +10.28%
                        Column ranges - batch |   221 |    245 | +10.86%

@@ -1,4 +1,4 @@
import {CellValue, ConfigParams, HyperFormula, Sheet} from '../../src'
import {CellValue, ConfigParams, HyperFormula, NoErrorCellValue, Sheet} from '../../src'

Check notice

Code scanning / CodeQL

Unused variable, import, function or class

Unused import NoErrorCellValue.
@sequba sequba changed the title Typescript 5 upgrade Upgrade typescript, typedoc & vuepress May 10, 2023
@sequba sequba linked an issue May 11, 2023 that may be closed by this pull request
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.19%. Comparing base (0921593) to head (b2cdc52).
Report is 99 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1262      +/-   ##
===========================================
+ Coverage    97.17%   97.19%   +0.01%     
===========================================
  Files          165      166       +1     
  Lines        14219    14238      +19     
  Branches      3020     2965      -55     
===========================================
+ Hits         13818    13838      +20     
- Misses         396      400       +4     
+ Partials         5        0       -5     
Files with missing lines Coverage Δ
src/ArrayValue.ts 100.00% <100.00%> (ø)
...c/DependencyGraph/AddressMapping/AddressMapping.ts 88.00% <100.00%> (ø)
...Graph/AddressMapping/ChooseAddressMappingPolicy.ts 100.00% <ø> (ø)
...rc/DependencyGraph/AddressMapping/DenseStrategy.ts 100.00% <100.00%> (ø)
...c/DependencyGraph/AddressMapping/SparseStrategy.ts 100.00% <100.00%> (ø)
src/DependencyGraph/FormulaCellVertex.ts 84.00% <100.00%> (ø)
src/errors.ts 100.00% <100.00%> (ø)
src/format/format.ts 99.30% <100.00%> (ø)
src/helpers/licenseKeyHelper.ts 100.00% <ø> (ø)
src/index.ts 100.00% <ø> (ø)
... and 8 more

... and 23 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix npm audit reports
1 participant