🥸 : Optimise updating state #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have optimised the performance by adding a verify function to verify if there are changes in the state's value. This is done by comparing the old value with the new one. This thus helps in less energy, CPU usage in large apps.:
haneenmahd
commented
Jul 30, 2022
lib/State.ts
Outdated
| * @param {T} newValue | ||
| * @returns {boolean} | ||
| */ | ||
| verifyValue(newValue: string) { |
There was a problem hiding this comment.
The newValue should be of generic type T
haneenmahd
commented
Jul 30, 2022
| * @returns {boolean} | ||
| */ | ||
| verifyValue(newValue: T): boolean { | ||
| return this.value !== newValue; |
There was a problem hiding this comment.
Previously, I compared if it is equal to the new value and resulted in a bug, that will prevent from setting the state value. Now, we will verify if the value is not same as the old one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimised the performance of updating a state by only updating if the new value is not equal to the old one.