Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

needs to return app #4

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Conversation

nebukadhezer
Copy link
Contributor

Hey sorry I had forgotten to PR this...
either we return app or getattr(sys.modules[name], app.id)

@hannesdelbeke
Copy link
Owner

What s the change to app return for?
Asking since some other repos depend on this i believe

@nebukadhezer
Copy link
Contributor Author

For me this crashes with an error as app is an Instance of "class App"
and not a str. Getattr needs a string so either we just return the app (as we already have it from the for loop)
or we use app.id to get another instance of the app we want to have.

Please just test this at your end, it does not work as it is atm.
For example in maya...

@hannesdelbeke
Copy link
Owner

ah thanks for explaining, will test

@nebukadhezer
Copy link
Contributor Author

Any news here ?
Cheers

@hannesdelbeke hannesdelbeke merged commit 332a65a into hannesdelbeke:main Sep 14, 2023
@hannesdelbeke
Copy link
Owner

havent been able to test
don't have free time atm. looking at the code it seems like it make sense though, merged!

@hannesdelbeke
Copy link
Owner

hannesdelbeke commented Oct 11, 2023

this PR possibly broke plugget. bug: plugget/plugget-qt#9
detect_app now thinks we run in Ansible (first app entry) instead of Blender

@hannesdelbeke
Copy link
Owner

hannesdelbeke commented Oct 11, 2023

confirmed

  • latest version 0.0.3 is working fine
  • latest on this repo is broken

@hannesdelbeke
Copy link
Owner

was a small bug with upgrading the import fallback part, fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants