Fix potential soundness hole in version comparison #1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This guarantees that a `RawVersion` can't be constructed from outside of its module, allowing its methods to make more assumptions about its fields. The benefits of this aren't realized yet.
There was no `Version`, so need for a prefix to distinguish this struct from anything else. Any raw-ness that is inherent to it is an implementation detail, and doesn't' need to be reflected in the name.
This is needed to be able to pass a `String` to `#[command]` attributes `version` parameter, which I'm about to do.
Store `Version` in the version `static`s, instead of storing a `&'static str` there and converting the version from that. Going over the relevant parts of the standard library documentation with a fine comb, I realized that a pointer casted from a reference is only valid, if only raw pointers are used to access that memory.[1] I don't know if this carries over to the pointer returned by `str::as_ptr`, but if it does, this could have indeed been a soundness hole, as the original `str` is still used, in `fj-app`'s `args` module. [1]: https://doc.rust-lang.org/std/ptr/index.html#safety
This was referenced Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From one of the commit messages:
This could be the fix required for #1307, but having no access to Windows, I cannot be sure.