Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model version check is disabled on Windows #1307

Closed
hannobraun opened this issue Nov 4, 2022 · 3 comments · Fixed by #1374
Closed

Model version check is disabled on Windows #1307

hannobraun opened this issue Nov 4, 2022 · 3 comments · Fixed by #1374
Labels
help wanted Extra attention is needed type: bug Something isn't working

Comments

@hannobraun
Copy link
Owner

hannobraun commented Nov 4, 2022

When loading a model, the Fornjot app checks the Fornjot version that this model model uses, to prevent mystery errors due to incompatibilities. This check is currently disabled on Windows. There's a bug that prevents it from working there. See #1303 for context.

It would be great if we fixed that bug, and enabled the same version check on all platforms. Unfortunately, I don't have access to a Windows machine and lack Windows expertise. Labeling as https://github.com/hannobraun/Fornjot/labels/help%20wanted, as help would be especially appreciated!

@hannobraun
Copy link
Owner Author

I went over the version comparison code with a fine comb and found (and fixed!) a potential soundness hole. I don't know if that was actually the problem reported in #1303, but if it was, it's possible that the version check can be enabled on Windows without further changes.

@MartinKavik
Copy link
Contributor

I've just pulled the latest main and deleted the condition for Windows and tried println! the versions and everything seems to work as expected now on Windows 10. Good job!

Btw is it possible to somehow filter debug! messages for a specific crate or a project? When I set RUST_LOG=DEBUG I see only a sea of wgpu_* and fj_viewer* messages.

@hannobraun
Copy link
Owner Author

I've just pulled the latest main and deleted the condition for Windows and tried println! the versions and everything seems to work as expected now on Windows 10. Good job!

Thank you! Such a subtle thing. I wasn't very optimistic that this would actually solve it!

Btw is it possible to somehow filter debug! messages for a specific crate or a project? When I set RUST_LOG=DEBUG I see only a sea of wgpu_* and fj_viewer* messages.

Yes: RUST_LOG=fj_host=debug cargo run

I think you can go even more fine-grained, by specifying this on the module level. And you can probably chain multiple directives using ,, but I might not remember the syntax correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed type: bug Something isn't working
Projects
None yet
2 participants