Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a hacky model bounding box info to rendering UI #217

Merged
merged 1 commit into from
Feb 20, 2022

Conversation

therealprof
Copy link
Contributor

Closes #134

Signed-off-by: Daniel Egger daniel@eggers-club.de

Closes hannobraun#134

Signed-off-by: Daniel Egger <daniel@eggers-club.de>
@therealprof
Copy link
Contributor Author

@hannobraun As you mentioned the current model rendering and UI code is a bit limited so maybe this would suffice as temporary hack.

Copy link
Owner

@hannobraun hannobraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @therealprof, looks good!

As you mentioned the current model rendering and UI code is a bit limited so maybe this would suffice as temporary hack.

Yes, definitely. No point in trying to have the perfect UI, based on the current infrastructure 😄

@hannobraun hannobraun merged commit a2058a9 into hannobraun:main Feb 20, 2022
@therealprof therealprof deleted the hacky-bounding-box branch February 20, 2022 11:16
@therealprof
Copy link
Contributor Author

Whoops, I noticed I forgot to add a ChangeLog entry. 😅

@hannobraun
Copy link
Owner

Whoops, I noticed I forgot to add a ChangeLog entry. 😅

That's actually not necessary! I prefer to update the changelog at release time. That puts less of a burden on contributors and is not much extra work for me, since I edit the changelog pretty heavily anyways (by grouping related work into a single entry, for example).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding dimension rendering?
2 participants