Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding dimension rendering? #134

Closed
therealprof opened this issue Feb 6, 2022 · 1 comment · Fixed by #217
Closed

Adding dimension rendering? #134

therealprof opened this issue Feb 6, 2022 · 1 comment · Fixed by #217
Labels
topic: display Displaying Fornjot models type: feature New features and improvements to existing features

Comments

@therealprof
Copy link
Contributor

I was having a quick look at how difficult it would be to add an overlay to display the dimensions of the rendered object but I got lost in the tons of indirections to figure out where the actually rendered data would have to be created.

@hannobraun
Copy link
Owner

Thanks for opening this issue, @therealprof!

I think displaying the model dimensions makes sense. We already compute an axis-aligned bounding box, and that information could be displayed on screen.

Currently the only place where that kind of thing is done is for the config UI (the three lines of text at the top of the screen). See graphics/config_ui.rs. If you want to add more UI elements, the best place to start is to extend/adapt this code.

Please note that the current UI code is temporary, and I'd like to replace it with something more versatile (see #116). I don't intend to work on any UI stuff until that happens, personally. But I don't see any harm in extending what's currently there a bit more, if you're interested in working on that.

@hannobraun hannobraun added topic: display Displaying Fornjot models topic: ui type: feature New features and improvements to existing features labels Feb 7, 2022
therealprof added a commit to therealprof/Fornjot that referenced this issue Feb 19, 2022
Closes hannobraun#134

Signed-off-by: Daniel Egger <daniel@eggers-club.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: display Displaying Fornjot models type: feature New features and improvements to existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants