Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Computation of focus point is not fully correct #18

Closed
hannobraun opened this issue Dec 4, 2021 · 2 comments · Fixed by #644
Closed

Computation of focus point is not fully correct #18

hannobraun opened this issue Dec 4, 2021 · 2 comments · Fixed by #644
Labels
topic: display Displaying Fornjot models type: bug Something isn't working

Comments

@hannobraun
Copy link
Owner

The focus point is the point on the model (in model coordinates) that the mouse cursor points at. This point is used for input, for example when rotating the model, it is rotated around the focus point.

This works mostly, but not fully. The focus point is not detected correctly when the cursor still points at the model, but just barely. Maybe the graphics and the focus point computations use slightly different perspectives, leading to some distortion. This also seems dependent on window size (or at least aspect ratio), as the effect is less pronounced when the window is square.

It might help to implement #17 first, to show what's going on.

@hannobraun hannobraun added type: bug Something isn't working topic: display Displaying Fornjot models labels Dec 4, 2021
hannobraun added a commit that referenced this issue Dec 4, 2021
This doesn't work perfectly yet, probably due to #18.
@hannobraun
Copy link
Owner Author

I'd like to add to that that rotation seems a bit weird. It seems to me like it doesn't rotate around the focus point, but a point somewhat offset from that.

Not sure if that was broken from the beginning and I'm just noticing, or if I broke something in the last few days. I'm not really keen to look into it, as long as #17 remains unimplemented.

@hannobraun
Copy link
Owner Author

@chrisprice fixed the problem I described in the issue description in #614. The problem I described in my follow-up comment (the model not rotating around the focus point) is still present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: display Displaying Fornjot models type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant