Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up approximation code #1084

Merged
merged 9 commits into from
Sep 14, 2022
Merged

Clean up approximation code #1084

merged 9 commits into from
Sep 14, 2022

Commits on Sep 14, 2022

  1. Make constructor easier to call

    @hannobraun
    hannobraun committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    2b4dfd3 View commit details
    Browse the repository at this point in the history

  2. Simplify RangeOnCurve 

    It used to need those `Vertex` instances, but other things have changed
since then to allow for this simplification now.
    @hannobraun
    hannobraun committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    dd7f532 View commit details
    Browse the repository at this point in the history

  3. Add nicer API to CurveApprox 

    This doesn't have much of a positive impact on the current code, but
it's going to be nicer for writing tests.
    @hannobraun
    hannobraun committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    f46ffa6 View commit details
    Browse the repository at this point in the history

  4. Make Approx methods more convenient to call

    @hannobraun
    hannobraun committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    3e82dc6 View commit details
    Browse the repository at this point in the history

  5. Make RangeOnCurve::new more convenient to call

    @hannobraun
    hannobraun committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    a747e62 View commit details
    Browse the repository at this point in the history

  6. Move GlobalPath approximation code to path

    @hannobraun
    hannobraun committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    a9840b1 View commit details
    Browse the repository at this point in the history

  7. Rename RangeOnCurve to RangeOnPath 

    The new name more accurately reflects its use.
    @hannobraun
    hannobraun committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    bd699c9 View commit details
    Browse the repository at this point in the history

  8. Update doc comment

    @hannobraun
    hannobraun committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    c29e858 View commit details
    Browse the repository at this point in the history

  9. Move RangeOnPath to path

    @hannobraun
    hannobraun committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    ddce27e View commit details
    Browse the repository at this point in the history