Clean up partial object API, update its documentation #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The word "form" is already used to describe variants of objects that exist in different coordinate systems (e.g. surface and global forms of a vertex). Since this is a different concept, let's avoid that word here.
hannobraun
force-pushed
the
ready/partial
branch
from
e3e0902
to
2e274e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The partial object API, while certainly not final (nothing is), has reached a point where it is definitely useful. I've managed to use it already to solve a lot of the problems encountered in #1079. This pull request builds on that early success by doing a bit of polishing.