Move cycle validation to new infrastructure #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already check that all half-edges are connected by identical surface vertices. Checking the surface on top of that is redundant.
I'm currently writing some code that requires more from that type than just `Iterator`. Using a concrete type seems more practical than specifying all kinds of additional bounds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another step towards getting the validation code cleaned up, which I want to do before writing the new validation code required for #1162. The remaining piece I want to move is face validation.
Also includes a number of minor cleanups and additions of the partial object and builder APIs, which came out of this work.