Clean up surface-related code; prepare for deeper integration into partial object API #1340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm about to add new types that are similar to the path types, and having them in a common parent module makes sense. `geometry` isn't the greatest name for that new module (it's not like the things outside of it aren't geometry), but it's what I can come up with right now.
This is only the start of this particular refactoring. Eventually, all the math-y parts of `Surface` will live in `SurfaceGeometry`. This has the advantage of decoupling those math-y parts from the existence of a `Surface`, which means they can be used as part of a hypothetical `PartialSurface`.
It won't be able to support all of them going forward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits off the math-y parts of
Surfaceinto a separate struct. This allows these math-y parts to be reused without aSurfacehaving to be present, for example in a partial version ofSurface.This pull request adds this partial version,
PartialSurface, but doesn't really make use of it yet. I've been running into some hurdles (in the form of test failures) when trying to do that, and I believe this will become much easier to clean up once I clean up the partial object API further (#1249).