Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up MaybePartial transform code #1361

Merged
merged 7 commits into from
Nov 16, 2022
Merged

Clean up MaybePartial transform code #1361

merged 7 commits into from
Nov 16, 2022

Commits on Nov 16, 2022

  1. Refactor

    @hannobraun
    hannobraun committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    3a57c6a View commit details
    Browse the repository at this point in the history

  2. Add MaybePartial<GlobalVertex>::position

    @hannobraun
    hannobraun committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    29c547d View commit details
    Browse the repository at this point in the history

  3. Be more careful about overriding global vertex pos 

    The previous approach could lead to conflicts (resulting in a panic)
under certain constellations.
    @hannobraun
    hannobraun committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    3bbd1ad View commit details
    Browse the repository at this point in the history

  4. Make MaybePartial transform result in partial 

    This provides the caller with more flexibility.
    @hannobraun
    hannobraun committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    37c6d96 View commit details
    Browse the repository at this point in the history

  5. Refactor

    @hannobraun
    hannobraun committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    c185a07 View commit details
    Browse the repository at this point in the history

  6. Add comment

    @hannobraun
    hannobraun committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    6e8524f View commit details
    Browse the repository at this point in the history

  7. Refactor

    @hannobraun
    hannobraun committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    e34db7e View commit details
    Browse the repository at this point in the history