Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify CycleBuilder and FaceBuilder #1467

Merged
merged 12 commits into from
Dec 20, 2022
Merged

Simplify CycleBuilder and FaceBuilder #1467

merged 12 commits into from
Dec 20, 2022

Commits on Dec 20, 2022

  1. Refactor

    @hannobraun
    hannobraun committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    d15d090 View commit details
    Browse the repository at this point in the history

  2. Make variable name more explicit

    @hannobraun
    hannobraun committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    f145eec View commit details
    Browse the repository at this point in the history

  3. Refactor

    @hannobraun
    hannobraun committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    6b61db0 View commit details
    Browse the repository at this point in the history

  4. Remove unused method

    @hannobraun
    hannobraun committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    637400e View commit details
    Browse the repository at this point in the history

  5. Add surface field to PartialCycle 

    This is redundant right now, but I'm going to change `CycleBuilder` to
use that field for new half-edges. This will make it possible to define
the surface of a cycle, before adding any half-edges.
    @hannobraun
    hannobraun committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    4a7222b View commit details
    Browse the repository at this point in the history

  6. Use PartialCycle's surface when adding edges

    @hannobraun
    hannobraun committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    cea12aa View commit details
    Browse the repository at this point in the history

  7. Remove redundant method argument

    @hannobraun
    hannobraun committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    fed44a5 View commit details
    Browse the repository at this point in the history

  8. Simplify FaceBuilder::update_exterior_as_polygon

    @hannobraun
    hannobraun committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    3bdc46e View commit details
    Browse the repository at this point in the history

  9. Create Partial only once 

    This doesn't really make a difference in functionality, but it seems a
bit cleaner, and possibly more robust in the face of future changes.
    @hannobraun
    hannobraun committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    8c5b5ca View commit details
    Browse the repository at this point in the history

  10. Inline variables

    @hannobraun
    hannobraun committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    0b33e56 View commit details
    Browse the repository at this point in the history

  11. Remove redundant method argument

    @hannobraun
    hannobraun committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    a8aa325 View commit details
    Browse the repository at this point in the history

  12. Remove redundant method argument

    @hannobraun
    hannobraun committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    649e313 View commit details
    Browse the repository at this point in the history