Remove position fields of SurfaceVertex/PartialSurfaceVertex
#1640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This check is more thorough, but it also bypasses the surface position, which I'm about to remove.
The next commit is going to make this check redundant.
They have become redundant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build on the previous work done in #1635 to also compute the start position of
PartialHalfEdge, making thepositionfields ofSurfaceVertex/PartialSurfaceVertexcompletely redundant, allowing them to be removed here.This is not only a big simplification in itself (230 lines removed, along with lots of opportunities to make mistakes), it also sets
SurfaceVertex/PartialSurfaceVertexup for the ultimate simplification, i.e. complete removal.Close #1634