Make sweep operation triangle-less #178
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 15, 2022
Merged
Merged
hannobraun
force-pushed
the
sweep
branch
4 times, most recently
from
2889d30
to
823229a
Compare
hannobraun
force-pushed
the
sweep
branch
2 times, most recently
from
2ba476f
to
013929b
Compare
hannobraun
force-pushed
the
sweep
branch
2 times, most recently
from
6d1f8cf
to
5445ab9
Compare
Instead of cloning the source face, then adding the top faces, this commit updates the sweep algorithm to add the bottom faces explicitly. This adds a lot of tedious code. The advantage is, that now we can add another relation of bottom-to-top topology, which is needed for creating the side faces. I believe that there's a better API hidden within `Shape`, that will make code like this much cleaner. I am only starting to imagine what that API would look like though, so for now, this mess is what we get instead.
Generate non-continuous side faces of a sweep using boundary representation. The only case that still uses triangle representation are continuous side faces of a sweep.
|
Closing in favor of #355. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my work-in-progress towards addressing #97. The goal is to keep this pull request small, and land any self-contained pieces in separate pull requests.