Rework Sketches v2 #1828
Rework Sketches v2 #1828
Conversation
| ) -> Self::Approximation { | ||
| self.faces().approx_with_cache(tolerance, cache) | ||
| todo!() |
There was a problem hiding this comment.
Left this as a todo!() for now as I'm not aware that we need to approximate Sketches directly yet, we always first turn them into faces/shells and then approximate?
There was a problem hiding this comment.
Yeah, fair enough. We can fill this in once required 👍
There was a problem hiding this comment.
Thank you, @A-Walrus, looks great!
I found one typo and left a comment with a suggestion. I can probably apply that myself, after submitting this review.
Not sure how to test that this is working with the new changes? Tests are passing, but other than that I don't know what to check...
Yeah, sorry. We temporarily lost the example models, and the automated testing associated with them. I'll re-add those soon. For now, I'm happy to merge anything that compiles and looks reasonable.
| ) -> Self::Approximation { | ||
| self.faces().approx_with_cache(tolerance, cache) | ||
| todo!() |
There was a problem hiding this comment.
Yeah, fair enough. We can fill this in once required 👍
Version 2 of #1801, this version is rebased and much simpler. Not sure how to test that this is working with the new changes? Tests are passing, but other than that I don't know what to check...