Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dedicated struct to represent boundaries on curves #1941

Merged
merged 24 commits into from
Jul 17, 2023
Merged

Use dedicated struct to represent boundaries on curves #1941

merged 24 commits into from
Jul 17, 2023

Commits on Jul 17, 2023

  1. Rename RangeOnPath to BoundaryOnCurve 

    I intend to use this struct more broadly, outside of the approximation
code, and this is the start of a cleanup effort meant to enable this.
    @hannobraun
    hannobraun committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    d9f4d08 View commit details
    Browse the repository at this point in the history

  2. Update variable name

    @hannobraun
    hannobraun committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    46bb8c7 View commit details
    Browse the repository at this point in the history

  3. Inline redundant variable

    @hannobraun
    hannobraun committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    34d4aaa View commit details
    Browse the repository at this point in the history

  4. Update argument name

    @hannobraun
    hannobraun committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    60292a2 View commit details
    Browse the repository at this point in the history

  5. Update argument name

    @hannobraun
    hannobraun committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    548b0e1 View commit details
    Browse the repository at this point in the history

  6. Update word in comment

    @hannobraun
    hannobraun committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    3bdaf64 View commit details
    Browse the repository at this point in the history

  7. Update argument name

    @hannobraun
    hannobraun committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    24dd5f7 View commit details
    Browse the repository at this point in the history

  8. Update variable name

    @hannobraun
    hannobraun committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    d22aaef View commit details
    Browse the repository at this point in the history

  9. Update argument name

    @hannobraun
    hannobraun committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    b82266c View commit details
    Browse the repository at this point in the history

  10. Update variable name

    @hannobraun
    hannobraun committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    3d71d4d View commit details
    Browse the repository at this point in the history

  11. Update argument name

    @hannobraun
    hannobraun committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    c6599ad View commit details
    Browse the repository at this point in the history

  12. Update variable name

    @hannobraun
    hannobraun committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    d0f3cc1 View commit details
    Browse the repository at this point in the history

  13. Update argument name

    @hannobraun
    hannobraun committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    f87de6d View commit details
    Browse the repository at this point in the history

  14. Update struct field name

    @hannobraun
    hannobraun committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    bee1de6 View commit details
    Browse the repository at this point in the history

  15. Update documentation of BoundaryOnCurve

    @hannobraun
    hannobraun committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    b5235ca View commit details
    Browse the repository at this point in the history

  16. Move BoundaryOnCurve to geometry 

    I'd like to use it outside of the approximation code.
    @hannobraun
    hannobraun committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    e3e86d2 View commit details
    Browse the repository at this point in the history

  17. Derive Hash for BoundaryOnCurve

    @hannobraun
    hannobraun committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    dc5421e View commit details
    Browse the repository at this point in the history

  18. Use BoundaryOnCurve in HalfEdge

    @hannobraun
    hannobraun committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    e35456d View commit details
    Browse the repository at this point in the history

  19. Refactor to prepare for follow-on change

    @hannobraun
    hannobraun committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    483cbce View commit details
    Browse the repository at this point in the history

  20. Return BoundaryOnCurve from HalfEdge::boundary

    @hannobraun
    hannobraun committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    6e46b97 View commit details
    Browse the repository at this point in the history

  21. Inline redundant variable

    @hannobraun
    hannobraun committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    5b0e736 View commit details
    Browse the repository at this point in the history

  22. Make more use of BoundaryOnCurve

    @hannobraun
    hannobraun committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    a0e2190 View commit details
    Browse the repository at this point in the history

  23. Make more use of BoundaryOnCurve

    @hannobraun
    hannobraun committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    0e3c716 View commit details
    Browse the repository at this point in the history

  24. Refactor to consolidate redundant code

    @hannobraun
    hannobraun committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    8607aa0 View commit details
    Browse the repository at this point in the history