Make sure that the coordinate systems of locally defined curves match #1982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure that each of the local definitions match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Curves (which define the geometry of half-edges) are defined locally, in surface coordinates. For that to be valid, those local definitions need to result in the same curves in 3D space, of course. And they already did, but the coordinate systems of those curves would not always match. That meant, if you converted a point in local curve coordinates, say
0, into global 3D coordinates, you could get different points, according to which local definition you used.This wasn't a problem so far, but it has started to become one. #1968 is an example of that, but #1937 is blocked by that also.
This pull request fixes all existing coordinate system mismatches, and adds a validation check to make sure those can never happen again, meaning any code dealing with curves can now rely on the coordinate systems to always make sense.
Close #1973