Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow valid Cycles to be empty; validate Face boundary instead #2095

Merged
merged 11 commits into from
Nov 15, 2023
Merged

Allow valid Cycles to be empty; validate Face boundary instead #2095

merged 11 commits into from
Nov 15, 2023

Commits on Nov 15, 2023

  1. Update validation error messages

    @hannobraun
    hannobraun committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    a5b4091 View commit details
    Browse the repository at this point in the history

  2. Improve formatting of validation errors

    @hannobraun
    hannobraun committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    5a502ac View commit details
    Browse the repository at this point in the history

  3. Improve name of enum variant 

    I think "disconnected" can be understood to imply that they were
connected in the first place, while "not connected" does carry no such
connotation.

Also, `Edge` has been renamed to `HalfEdge` a while ago, so that part of
the new name is also more accurate.
    @hannobraun
    hannobraun committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    035df3f View commit details
    Browse the repository at this point in the history

  4. Update function name

    @hannobraun
    hannobraun committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    bb35584 View commit details
    Browse the repository at this point in the history

  5. Simplify test name

    @hannobraun
    hannobraun committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    6561290 View commit details
    Browse the repository at this point in the history

  6. Allow valid Cycles to be empty 

    That empty cycles are invalid makes the result of `BuildFace::unbound`
invalid by default, requiring a hacky workaround
(`Services::only_validate`).

I think empty cycles are actually fine. What's a problem is, if such an
empty cycle is used as the exterior of a face, and I will add a
validation check for that specifically.
    @hannobraun
    hannobraun committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    083c2d1 View commit details
    Browse the repository at this point in the history

  7. Validate that Faces have a boundary

    @hannobraun
    hannobraun committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    be644bc View commit details
    Browse the repository at this point in the history

  8. Remove workaround that is no longer required

    @hannobraun
    hannobraun committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    5347ac4 View commit details
    Browse the repository at this point in the history

  9. Remove unused code

    @hannobraun
    hannobraun committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    f2aa180 View commit details
    Browse the repository at this point in the history

  10. Update documentation of Insert::insert

    @hannobraun
    hannobraun committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    7e18882 View commit details
    Browse the repository at this point in the history

  11. Update documentation of validation module

    @hannobraun
    hannobraun committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    7a501d4 View commit details
    Browse the repository at this point in the history