Add operation for splitting faces #2097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`0.5`, what was used before, is a bit of an edge case that could work, even if some of the code is buggy. Using a less special value is a better test case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement an operation that can split a face of a shell along a line.
You can see the split face in this screenshot by the way the shell is triangulated. If there was a single square face facing the camera, it would get triangulated in the minimal way, using two triangles. However, the line through the center that is visible here is the boundary between two faces.
Splitting faces is not useful in itself, but it provides a building block for more complex modeling operations. For example, once it is possible to add to a shell by extruding from one of its faces, then splitting faces becomes a very valuable way to control this capability.
Close #2023