Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race condition when loading model initially #380

Merged
merged 17 commits into from
Mar 18, 2022
Merged

Fix race condition when loading model initially #380

merged 17 commits into from
Mar 18, 2022

Commits on Mar 18, 2022

  1. Add Model::watch

    @hannobraun
    hannobraun committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    93b8d0d View commit details
    Browse the repository at this point in the history

  2. Inline method call

    @hannobraun
    hannobraun committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    3b0bbf9 View commit details
    Browse the repository at this point in the history

  3. Make error returned by Model::watch more general

    @hannobraun
    hannobraun committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    da3c599 View commit details
    Browse the repository at this point in the history

  4. Add separate shape loading code path for export 

    This enables some fixes and cleanups, as both code paths can now be
changed independently.
    @hannobraun
    hannobraun committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    2294467 View commit details
    Browse the repository at this point in the history

  5. Simplify variable name

    @hannobraun
    hannobraun committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    4e46824 View commit details
    Browse the repository at this point in the history

  6. Add model::Watcher

    @hannobraun
    hannobraun committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    c2dbbf3 View commit details
    Browse the repository at this point in the history

  7. Move model loading into Watcher 

    This is slightly more complex, but makes it easier to trigger a model
load from other sources than the watcher thread.
    @hannobraun
    hannobraun committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    3a35b4b View commit details
    Browse the repository at this point in the history

  8. Prepare main loop for not having camera available 

    This will help with a fix I'm working on.
    @hannobraun
    hannobraun committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    1227f69 View commit details
    Browse the repository at this point in the history

  9. Prevent race condition when watching model 

    This temporarily leads to two initial loads of the model. I'm going to
fix that in subsequent commits.
    @hannobraun
    hannobraun committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    6568d0c View commit details
    Browse the repository at this point in the history

  10. Initialize camera on initial model load

    @hannobraun
    hannobraun committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    a34e872 View commit details
    Browse the repository at this point in the history

  11. Fix double-load of model on initialization

    @hannobraun
    hannobraun committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    920d470 View commit details
    Browse the repository at this point in the history

  12. Improve grouping of variables

    @hannobraun
    hannobraun committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    e5cd42a View commit details
    Browse the repository at this point in the history

  13. Rename variable

    @hannobraun
    hannobraun committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    baf7dde View commit details
    Browse the repository at this point in the history

  14. Rename variable

    @hannobraun
    hannobraun committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    3a5441f View commit details
    Browse the repository at this point in the history

  15. Simplify variable name

    @hannobraun
    hannobraun committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    3574ed4 View commit details
    Browse the repository at this point in the history

  16. Make method name more explicit

    @hannobraun
    hannobraun committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    b0d26c0 View commit details
    Browse the repository at this point in the history

  17. Make method name more explicit

    @hannobraun
    hannobraun committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    0b97a1a View commit details
    Browse the repository at this point in the history