Implement union operation #544
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannobraun
force-pushed
the
union
branch
5 times, most recently
from
5ceb0be
to
1d7f246
Compare
hannobraun
force-pushed
the
union
branch
6 times, most recently
from
6b90c23
to
f0a8909
Compare
The `Deref` seems more closely associated with the type than a `From` implementation for another type, so it makes sense to put the `impl` block for the `Deref` closer to the type.
Screenshot is missing.
|
This pull request is terribly out of date, and recent work has focused on implementing more of the intersection testing primitives required for implementing the union operation. I'm going to close this. I'll open a new PR, once enough of the intersection testing work has been finished, and I can work on the main algorithm again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My work-in-progress code towards addressing #42. I expect to land most of the required functionality in small increments, and will keep rebasing this pull request until all the pieces are in place.