Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for std::path reform in rustc version ba2f13ef0 #13

Merged
merged 2 commits into from
Feb 6, 2015
Merged

Update for std::path reform in rustc version ba2f13ef0 #13

merged 2 commits into from
Feb 6, 2015

Conversation

daboross
Copy link
Contributor

@daboross daboross commented Feb 5, 2015

This updates for the changes to std::path added in rust-lang/rust#21759. (rfc: https://github.com/rust-lang/rfcs/blob/master/text/0474-path-reform.md)

  • Switches to using unix::OsStrExt (path.as_os_str().as_byte_slice()) for conversion from path to CString
  • Switches to using String::from_utf8() (String::from_utf8(c_str.as_bytes().to_vec())) for conversion from CString to String
  • Removes path feature, as it is no longer required

This updates for the changes to std::path, using unix::OsStrExt for conversion from path to CString, and just using String::from_utf8() for conversion from CString to String.
hannobraun added a commit that referenced this pull request Feb 6, 2015
Update for std::path reform in rustc version ba2f13ef0
@hannobraun hannobraun merged commit ebcdcd0 into hannobraun:master Feb 6, 2015
@hannobraun
Copy link
Owner

Excellent, thank you!

@daboross daboross deleted the update-to-rust-ba2f13ef0 branch March 20, 2015 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants